update mongo driver version #1148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esimonov
reviewed
Aug 29, 2024
| @@ -43,7 +43,10 @@ require ( | |||
| modernc.org/sqlite v1.18.1 | |||
| ) | |||
|
|
|||
| require github.com/jackc/puddle/v2 v2.2.1 // indirect | |||
| require ( | |||
There was a problem hiding this comment.
I think this should be combined with the block below.
bart1024
reviewed
Nov 3, 2024
Comment on lines
+39
to
+41
| {ImageName: "postgres:13", Options: opts}, | ||
| {ImageName: "postgres:14", Options: opts}, | ||
| {ImageName: "postgres:15", Options: opts}, |
There was a problem hiding this comment.
It's weird to see postgres-related changes in PR titled as "update mongo driver version"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongo has released >1.15 version and we use "GODRIVER-2081 Add support for AWS IAM Roles for service accounts." feature added in this release of mongo-driver.
Update
go.mongodb.org/mongo-driver v1.7.5 -> v1.15.1
PS. v1.15.1 does not support mongodb 3.4, which are in tests after I tried to update locally. I can open a PR for review if needed