Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: remove deprecated linter & fix lint #1104

Closed
Shion1305 opened this issue Jun 5, 2024 · 1 comment
Closed

golangci-lint: remove deprecated linter & fix lint #1104

Shion1305 opened this issue Jun 5, 2024 · 1 comment

Comments

@Shion1305
Copy link
Contributor

Describe the Bug

When you run golangci-lint on this repository now, you'll get following errors.
image

Here is the problem...

Steps to Reproduce

Just run the latest version of golangci-lint.
You can also reproduce by rerunning CI again.
This was referenced Jun 5, 2024
Merged
Merged
Merged
cbergoon added a commit to ODWLTS/migrate that referenced this issue Jun 6, 2024
@cbergoon
Changes borrowed from PR golang-migrate#1104 to fix linting.
ed8b8b7
dhui added a commit that referenced this issue Jun 10, 2024
@dhui
Merge pull request #1105 from Shion1305/shion/issue-1104
b16220c 
#1104 Fix golanglint-ci lint config & lint errors
@dhui
Copy link
Member

dhui commented Jun 10, 2024

Not sure why github didn't auto-resolve this issue. It's fixed by #1105

@dhui dhui closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhui @Shion1305