Bug Fix #3255#3
Closed
taggie05 wants to merge 2 commits into
Closed
Conversation
I changed overflow-y from auto to hidden.
Owner
|
Perfect! |
gokunymbus
requested changes
Nov 11, 2017
| .main { | ||
| background-color: $ms-color-white; | ||
| overflow-x: hidden; | ||
| overflow-y: auto; |
Owner
There was a problem hiding this comment.
Would you mind providing a before and after screenshot? I just wan't to make sure this fixes the problem. Thank you!!
Author
There was a problem hiding this comment.
When I change the this is what I get on my local machine when I do the changes
gokunymbus
approved these changes
Nov 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft#3255
Include a change request file using $ npm run change
Description of changes
I changed overflow-y from auto to hidden.
I'm not sure if this is the correct file but the problem with the scroll bar is this issue. When you remove both overlfow-x and overflow-y the scroll bar disappears. If you change the overflow-y to hidden from auto it changes as well. I found the problem through the CSS. The link at the bottom is the CSS that I think the problem is connected to but I'm not 100% sure to be honest.
https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/office-ui-fabric-react/src/components/Callout/Callout.scss