Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use image previewers #531

Merged
merged 5 commits into from
Dec 24, 2020
Merged

Add ability to use image previewers #531

merged 5 commits into from
Dec 24, 2020

Commits on Dec 20, 2020

  1. Return early on error in nav.preview

    @neeshy
    neeshy committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    7380e2b View commit details
    Browse the repository at this point in the history

  2. nav.checkReg now returns a boolean instead of calling nav.preview

    @neeshy
    neeshy committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    9207e1a View commit details
    Browse the repository at this point in the history

  3. Pass width, height, x, and y parameters to preview script

    @neeshy
    neeshy committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    b33bea3 View commit details
    Browse the repository at this point in the history

  4. Check previewer for exit code 

    If non-zero the preview will be assumed to have side-effects.
    @neeshy
    neeshy committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    eff12fc View commit details
    Browse the repository at this point in the history

  5. Add the cleaner option 

    This is called upon selection changes if the previous preview was
volatile. To this end, volatilePreview was added to the nav struct
    @neeshy
    neeshy committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    219fd77 View commit details
    Browse the repository at this point in the history