Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better preview script integration (targeted at image previews) #304

Closed
wants to merge 31 commits into from
Closed

Better preview script integration (targeted at image previews) #304

wants to merge 31 commits into from

Commits on Aug 7, 2019

  1. Prepare lf to use stpv (image previews)

    @Naheel-Azawy
    Naheel-Azawy committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    9c6a0c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. removed syscall dependancy

    @Naheel-Azawy
    Naheel-Azawy committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    fa1e6a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2019

  1. added cleaner option

    @Naheel-Azawy
    Naheel-Azawy committed Aug 31, 2019
    Configuration menu
    Copy the full SHA
    f0f3fd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Clear the prevew before loading the new directory preview

    @Provessor
    Provessor committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    d3f2450 View commit details
    Browse the repository at this point in the history

  2. Update preview dimensions in nav on resize event 

    It works to achieve the image resize but can definitely use some
improvement
    @Provessor
    Provessor committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    8c64c0a View commit details
    Browse the repository at this point in the history

  3. Properly clear the preview on exit

    @Provessor
    Provessor committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    83f10cf View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into imgpv

    @Provessor
    Provessor committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ea8dfec View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. defer previewClear waiting 

    To ensure view is always cleared before ui is closed
    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    adb35b9 View commit details
    Browse the repository at this point in the history

  2. Reposition previewClear calling

    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    c461e29 View commit details
    Browse the repository at this point in the history

  3. Block new previews if previewer already loading

    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cfa47e8 View commit details
    Browse the repository at this point in the history

  4. Only clear preview if viewing a directory

    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f4c406d View commit details
    Browse the repository at this point in the history

  5. Do not block with previewClear() 

    Left from before preview() checked current file. Fixes a bug where
the ui would freeze when quitting during a preview load.
    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0d735be View commit details
    Browse the repository at this point in the history

  6. Also update the width, x and y after renew()

    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    a222fa5 View commit details
    Browse the repository at this point in the history

  7. Fix error where loading was not reset if exit code was not 5

    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0ca89fa View commit details
    Browse the repository at this point in the history

  8. Run cleaner on preview

    @Provessor
    Provessor committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    683bdb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Refactor around prevew() 

    It is now a goroutine that recieves messages through previewChan,
this simplifies the process of killing previewer when the file is
changed before preview completion.

Currently does not kill asyncronously, moving fast through files
will result (that are not cached) will result in a waiting time due
to the synchronous order of processes being killed
    @Provessor
    Provessor committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    1e6db39 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Merge remote-tracking branch 'origin/master' into imgpv

    @Provessor
    Provessor committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    16105ff View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Move preview logic into app.loop

    @Provessor
    Provessor committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    39b9e99 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Move logic into separate function to make use of defer and buffer reg… 

    …Chan
    @Provessor
    Provessor committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8eccbd4 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Reset nav and make dirChan clear the preview

    @Provessor
    Provessor committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    7656a9d View commit details
    Browse the repository at this point in the history

  2. Move previewGen and previewClear into ui

    @Provessor
    Provessor committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    7510a31 View commit details
    Browse the repository at this point in the history

  3. Buffer delete channels to match copy and move 

    Fixes :delete not working
    @Provessor
    Provessor committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    03f384b View commit details
    Browse the repository at this point in the history

  4. gofmt

    @Provessor
    Provessor committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    0f1c8e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Only regenerate preview on new file, only clear preview when needed

    @Provessor
    Provessor committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    3f33e70 View commit details
    Browse the repository at this point in the history

  2. Fix preview clearing in incorrect situations

    @Provessor
    Provessor committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    9a27071 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. up, down, updir, open, top, bottom say whether the pointer has moved

    @Provessor
    Provessor committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    ff0c9c6 View commit details
    Browse the repository at this point in the history

  2. Only clear preview when necessary

    @Provessor
    Provessor committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    ab1b522 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into imgpv

    @Provessor
    Provessor authored Apr 11, 2020
    Configuration menu
    Copy the full SHA
    5eaeedc View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Fix preview not clearing on nav.currFile error or on ui.pause

    @Provessor
    Provessor committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    34fcf18 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'imgpv' of github.com:Provessor/lf into imgpv

    @Provessor
    Provessor committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    9c8fcfb View commit details
    Browse the repository at this point in the history

  3. Fix mess from merge

    @Provessor
    Provessor authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c61391b View commit details
    Browse the repository at this point in the history