Improvements to debugging. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue. The engine now relies on this value rather than on the name of the layer's current state. Debug statement will try to look for the layer's __framerInstanceInfo.name if no name is set. Running the focus engine with no initial focus set now fails gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked layers can now be queried directly for their focus boolean value.
The engine now relies on this value rather than on the name of the layer's current state. (It never failed previously, but this seems like a more reliable mechanism and so far it works at least as well.)
Debug statement will try to look for the layer's __framerInstanceInfo.name if no name is set. It's a private property, but a fallback is included.
Running the focus engine with no initial focus set now fails gracefully with error message.
Non-breaking change, should be seamless for the user.