Use sass --embedded once it's released #11059
Comments
|
Can you point to the released version of this |
The new version of |
Apologies, I didn't look into this enough. I'll add a comment updating this issue when the next version of dart-sass is released. |
bep
changed the title
|
Thanks, this is already on our radar, but need a Dart Sass release before we can implement this. |
|
I'll add to the requirement, "once it's released, and performance is roughly equivalent to the current embedded implementation." It may already be there, but my early (and perhaps poorly implemented) testing was not encouraging. |
|
@jmooring yea, well, this will all start out in https://github.com/bep/godartsass Which has some basic benchmarks which will hopefully give raise a red flag if the performance has taken a hit. Note that they also plan a change in the wire format (I'm not sure if that's implemented) that needs some update in the godartsass library to work -- as I understood it, that was motivated by performance. |
|
Here's the changes I mentioned above: sass/dart-sass#1980 |
|
A new version of Dart Sass has released with the inclusion of |
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. It seems to be twice as fast when running in parallel, but slightly slower serialized: ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. It seems to be twice as fast when running in parallel, but slightly slower serialized: ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. It seems to be twice as fast when running in parallel, but slightly slower serialized: ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/godartsass
that referenced
this issue
Jun 8, 2023
E.g. use `sass --embedded`. Note taht this will bumb to a new major version of this library (v2). If you need to support the old protocol/binary, use the v1 (root path) version. It seems to be twice as fast when running in parallel, but slightly slower serialized: ```bash name old time/op new time/op delta Transpiler/SCSS-10 114µs ± 0% 145µs ± 1% +26.40% (p=0.029 n=4+4) Transpiler/Start_and_Execute-10 25.6ms ± 2% 26.0ms ± 3% ~ (p=0.486 n=4+4) Transpiler/SCSS_Parallel-10 89.0µs ± 2% 44.4µs ± 3% -50.12% (p=0.029 n=4+4) name old alloc/op new alloc/op delta Transpiler/SCSS-10 1.33kB ± 1% 1.33kB ± 0% ~ (p=1.000 n=4+4) Transpiler/Start_and_Execute-10 22.4kB ± 1% 22.4kB ± 1% ~ (p=0.886 n=4+4) Transpiler/SCSS_Parallel-10 1.34kB ± 3% 1.33kB ± 1% ~ (p=1.000 n=4+4) name old allocs/op new allocs/op delta Transpiler/SCSS-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) Transpiler/Start_and_Execute-10 144 ± 1% 150 ± 0% +4.16% (p=0.029 n=4+4) Transpiler/SCSS_Parallel-10 18.0 ± 0% 18.0 ± 0% ~ (all equal) ``` See gohugoio/hugo#11059 Fixes #15
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 8, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 8, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 8, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 9, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 9, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 10, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
bep
added a commit
to bep/hugo
that referenced
this issue
Jun 12, 2023
|
Would it make sense to look into |
|
@XhmikosR maybe, but closed issues/PRs are closed and I almost never read comments in closed threads. I suggest you create a new issue. |
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi, the dart-sass-embedded compiler has been merged into dart-sass. Please consider using
sass --embeddedinstead ofdart-sass-embeddedfor forwards compatibility.The text was updated successfully, but these errors were encountered: