Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harbor_replication documentation bug #424

Closed
haiwu opened this issue Apr 2, 2024 · 1 comment · Fixed by #425
Closed

harbor_replication documentation bug #424

haiwu opened this issue Apr 2, 2024 · 1 comment · Fixed by #425

Comments

@haiwu
Copy link

haiwu commented Apr 2, 2024

Describe the bug
harbor_replication documentation bug with: https://github.com/goharbor/terraform-provider-harbor/blob/main/docs/resources/replication.md, where it has this example:

resource "harbor_replication" "alpine" {
  name        = "alpine"
  action      = "pull"
  registry_id = harbor_registry.main.registry_id
  schedule = "event_based"
  filters {
    name = "library/alpine"
  }
  filters {
    tag = "3.*.*"
  }
}

The above is wrong, 'event_based' is only possible for 'push' action', not 'pull' action.

To Reproduce
Just tried to ensure the above in the doc, it likely won't work.

Expected behavior
The example in the above doc should be 'push' action instead.

Additional context
N/A

flbla added a commit that referenced this issue Apr 8, 2024
flbla added a commit that referenced this issue Apr 8, 2024
flbla added a commit that referenced this issue Apr 8, 2024
@flbla flbla closed this as completed in #425 Apr 8, 2024
flbla added a commit that referenced this issue Apr 8, 2024
Signed-off-by: flbla <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@flbla
Copy link
Contributor

flbla commented Apr 8, 2024

Hi @haiwu,
Thank you for the bug report!
I fixed the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants