Skip to content

fix(portal): fix typo in ko-kr placeholder and update strings#22617

Merged
chlins merged 2 commits intogoharbor:mainfrom
g-yunjh:yunjh
Dec 5, 2025
Merged

fix(portal): fix typo in ko-kr placeholder and update strings#22617
chlins merged 2 commits intogoharbor:mainfrom
g-yunjh:yunjh

Conversation

@g-yunjh
Copy link
Copy Markdown
Contributor

@g-yunjh g-yunjh commented Dec 4, 2025

This PR updates the Korean translation file (ko-kr-lang.json) to improve coverage and accuracy.

Key Changes:

  • Fix Syntax Error: Fixed a broken placeholder in the SCAN_BY key where a closing brace was missing ({{scanner} -> {{scanner}}).
  • Update Translations: Translated previously untranslated keys such as MANDATORY, OVERRIDE, SIMPLE, ADVANCED, and STOP.
  • Refine Wording: Improved various UI strings to make them more natural and consistent with the context (e.g., Replication rules, Audit logs).

Issue being fixed

Fixes #22613

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@g-yunjh g-yunjh requested a review from a team as a code owner December 4, 2025 11:08
Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@wy65701436 wy65701436 added area/i18n Related to Translation changes. release-note/update Update or Fix labels Dec 4, 2025
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) December 4, 2025 12:23
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (64a8563).
⚠️ Report is 604 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22617       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76440    +70391     
- Misses       6983    35414    +28431     
- Partials      301     4241     +3940     
Flag Coverage Δ
unittests 65.84% <ø> (+20.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Fix broken placeholder syntax in 'SCAN_BY' value
- Update various UI strings for better readability
- Translate previously untranslated keys (MANDATORY, OVERRIDE, etc.)

Signed-off-by: g-yunjh <yunjh1126@naver.com>
auto-merge was automatically disabled December 4, 2025 14:35

Head branch was pushed to by a user without write access

Copy link
Copy Markdown
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chlins chlins enabled auto-merge (squash) December 5, 2025 02:05
@chlins chlins merged commit c0e0828 into goharbor:main Dec 5, 2025
12 checks passed
amaydixit11 pushed a commit to amaydixit11/harbor that referenced this pull request Dec 10, 2025
…or#22617)

- Fix broken placeholder syntax in 'SCAN_BY' value
- Update various UI strings for better readability
- Translate previously untranslated keys (MANDATORY, OVERRIDE, etc.)

Signed-off-by: g-yunjh <yunjh1126@naver.com>
Signed-off-by: Amay Dixit <amaydixit11@gmail.com>
intojhanurag pushed a commit to intojhanurag/harbor that referenced this pull request Jan 22, 2026
…or#22617)

- Fix broken placeholder syntax in 'SCAN_BY' value
- Update various UI strings for better readability
- Translate previously untranslated keys (MANDATORY, OVERRIDE, etc.)

Signed-off-by: g-yunjh <yunjh1126@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n Related to Translation changes. release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[i18n] Korean translation missing and incomplete translations

6 participants