Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #20603 #20824

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Aug 8, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: wang yan <[email protected]>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-2.11.0@73736af). Learn more about missing BASE report.

Files Patch % Lines
src/pkg/task/sweep_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20824   +/-   ##
=================================================
  Coverage                  ?   66.28%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113973           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75548           
  Misses                    ?    34306           
  Partials                  ?     4119           
Flag Coverage Δ
unittests 66.28% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/task/sweep_manager.go 36.22% <0.00%> (ø)

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit a3c69a6 into goharbor:release-2.11.0 Aug 8, 2024
13 of 15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants