Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Add menu item for ko_KR local #20633

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20600

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 20, 2024 05:23
@stonezdj stonezdj self-assigned this Jun 20, 2024
@stonezdj stonezdj assigned wy65701436 and zyyw and unassigned Vad1mo, chlins and MinerYang Jun 20, 2024
@stonezdj stonezdj requested review from zyyw and wy65701436 June 20, 2024 05:24
@stonezdj stonezdj changed the title Add menu item for ko_KR local [cherry-pick] Add menu item for ko_KR local Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@7025568). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20633   +/-   ##
=================================================
  Coverage                  ?   46.23%           
=================================================
  Files                     ?      247           
  Lines                     ?    13777           
  Branches                  ?     2845           
=================================================
  Hits                      ?     6370           
  Misses                    ?     7078           
  Partials                  ?      329           
Flag Coverage Δ
unittests 46.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 434b1af into goharbor:release-2.11.0 Jun 20, 2024
13 of 15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants