Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Use internal registry url to push artifact accessory #20581

Merged

Conversation

stonezdj
Copy link
Contributor

fixes #20565

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 12, 2024 07:03
@stonezdj stonezdj assigned wy65701436 and zyyw and unassigned zyyw, AllForNothing and MinerYang Jun 12, 2024
@stonezdj stonezdj changed the title Use internal registry url to push artifact accessory [cherry-pick] Use internal registry url to push artifact accessory Jun 12, 2024
@stonezdj stonezdj requested review from wy65701436 and zyyw June 12, 2024 07:04
@stonezdj stonezdj added the release-note/update Update or Fix label Jun 12, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@7025568). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20581   +/-   ##
=================================================
  Coverage                  ?   66.24%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113485           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75173           
  Misses                    ?    34202           
  Partials                  ?     4110           
Flag Coverage Δ
unittests 66.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 54.79% <100.00%> (ø)

@stonezdj stonezdj force-pushed the 2.11_use_internal_url_accessory branch from 80401bc to 2850e30 Compare June 12, 2024 07:22
@stonezdj stonezdj merged commit 5a06993 into goharbor:release-2.11.0 Jun 13, 2024
11 of 12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants