Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix label select bugs #19850

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix label select bugs #19850

merged 2 commits into from
Jan 18, 2024

Conversation

ShengqiWang
Copy link
Contributor

@ShengqiWang ShengqiWang commented Jan 17, 2024 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19839

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@ShengqiWang
fix label select bugs
8bbe301 
Signed-off-by: shengqiw <[email protected]>
@ShengqiWang ShengqiWang requested a review from a team as a code owner January 17, 2024 01:59
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (93d0d29) 70.65% compared to head (1ca2e0c) 45.36%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19850       +/-   ##
===========================================
- Coverage   70.65%   45.36%   -25.29%     
===========================================
  Files         747      244      -503     
  Lines       95839    13333    -82506     
  Branches        0     2720     +2720     
===========================================
- Hits        67711     6049    -61662     
+ Misses      24460     6983    -17477     
+ Partials     3668      301     -3367
Flag Coverage Δ
unittests 45.36% <50.00%> (-25.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/create-edit-rule/create-edit-rule.component.ts 35.71% <50.00%> (ø)

... and 990 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/update Update or Fix label Jan 17, 2024
wy65701436
wy65701436 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

xuelichao
xuelichao approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vad1mo Vad1mo enabled auto-merge (squash) January 17, 2024 11:31
@Vad1mo Vad1mo merged commit caaa641 into goharbor:main Jan 18, 2024
10 of 12 checks passed
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jan 19, 2024
@ShengqiWang @YangJiao0817
fix label select bugs (goharbor#19850)
ba2bc83 
Signed-off-by: shengqiw <[email protected]>
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jan 19, 2024
@ShengqiWang @YangJiao0817
fix label select bugs (goharbor#19850)
f5f466e 
Signed-off-by: shengqiw <[email protected]>
@YangJiao0817 YangJiao0817 mentioned this pull request Jan 19, 2024
Merged
5 tasks
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jan 19, 2024
@ShengqiWang @YangJiao0817
fix label select bugs (goharbor#19850)
52d7396 
Signed-off-by: shengqiw <[email protected]>
YangJiao0817 added a commit that referenced this pull request Jan 19, 2024
@YangJiao0817 @ShengqiWang
[cherry-pick]fix label select bugs (#19850) (#19862)
f5b8647 
fix label select bugs (#19850)

Signed-off-by: shengqiw <[email protected]>
Co-authored-by: ShengqiWang <[email protected]>
YangJiao0817 added a commit that referenced this pull request Jan 19, 2024
@YangJiao0817 @ShengqiWang
[cherry-pick]fix label select bugs (#19850) (#19861)
58892ae 
fix label select bugs (#19850)

Signed-off-by: shengqiw <[email protected]>
Co-authored-by: ShengqiWang <[email protected]>
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
@ShengqiWang
fix label select bugs (goharbor#19850)
5d3a2aa 
Signed-off-by: shengqiw <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@xuelichao xuelichao xuelichao approved these changes

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@AllForNothing AllForNothing

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replication rule filter with label not been updated via UI
5 participants
@ShengqiWang @wy65701436 @xuelichao @Vad1mo @AllForNothing