Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker version to 20.10.10 #19751

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Dec 21, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (923295c) 67.54% compared to head (ee1de01) 45.23%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19751       +/-   ##
===========================================
- Coverage   67.54%   45.23%   -22.31%     
===========================================
  Files         991      244      -747     
  Lines      109167    13332    -95835     
  Branches     2719     2719               
===========================================
- Hits        73738     6031    -67707     
+ Misses      31463     7000    -24463     
+ Partials     3966      301     -3665     
Flag Coverage Δ
unittests 45.23% <ø> (-22.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

Copy link

@yanji09 yanji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit e397e86 into goharbor:main Dec 26, 2023
19 of 20 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs Docs changes(made and needed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants