Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registryctl/api/registry/blob: fix dropped test error #19721

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Dec 15, 2023

This picks up a dropped test err variable in registryctl/api/registry/blob.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e5efc9) 70.63% compared to head (7b51b00) 45.30%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19721       +/-   ##
===========================================
- Coverage   70.63%   45.30%   -25.34%     
===========================================
  Files         747      244      -503     
  Lines       95833    13332    -82501     
  Branches        0     2719     +2719     
===========================================
- Hits        67696     6040    -61656     
+ Misses      24469     6990    -17479     
+ Partials     3668      302     -3366     
Flag Coverage Δ
unittests 45.30% <ø> (-25.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 991 files with indirect coverage changes

@stonezdj stonezdj added the release-note/update Update or Fix label Dec 19, 2023
@chlins chlins merged commit 49c5a06 into goharbor:main Jan 9, 2024
11 of 12 checks passed
Vad1mo pushed a commit that referenced this pull request Jan 26, 2024
* registryctl/api/registry/blob: fix dropped test error (#19721)

Signed-off-by: Lars Lehtonen <[email protected]>

* Remove robot account update quota permission (#19819)

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>

* Cache image list with digest key (#19801)

fixes #19429

Signed-off-by: stonezdj <[email protected]>
Co-authored-by: stonezdj <[email protected]>

* Add quota permissions testcase (#19822)

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>

* deprecate gosec in makefile (#19828)

remove the unused the part from makefile

Signed-off-by: wang yan <[email protected]>

* Add verification that robot account duration is not 0 (#19829)

Signed-off-by: Yang Jiao <[email protected]>

* fix artifact page bug (#19807)

* fix artifact page bug

* update testcase

* Upgrade to distribution (registry) v3 alpha

This includes all the benefits of the v3 distribution, but also all breaking changes.

Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers.

Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3.

Signed-off-by: Aaron Dewes <[email protected]>

---------

Signed-off-by: Lars Lehtonen <[email protected]>
Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: stonezdj <[email protected]>
Signed-off-by: wang yan <[email protected]>
Signed-off-by: Aaron Dewes <[email protected]>
Co-authored-by: Lars Lehtonen <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Co-authored-by: stonezdj(Daojun Zhang) <[email protected]>
Co-authored-by: stonezdj <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Co-authored-by: ShengqiWang <[email protected]>
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants