-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registryctl/api/registry/blob: fix dropped test error #19721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19721 +/- ##
===========================================
- Coverage 70.63% 45.30% -25.34%
===========================================
Files 747 244 -503
Lines 95833 13332 -82501
Branches 0 2719 +2719
===========================================
- Hits 67696 6040 -61656
+ Misses 24469 6990 -17479
+ Partials 3668 302 -3366
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
approved these changes
Dec 19, 2023
zyyw
approved these changes
Dec 19, 2023
Signed-off-by: Lars Lehtonen <[email protected]>
Vad1mo
approved these changes
Jan 9, 2024
Vad1mo
pushed a commit
that referenced
this pull request
Jan 26, 2024
* registryctl/api/registry/blob: fix dropped test error (#19721) Signed-off-by: Lars Lehtonen <[email protected]> * Remove robot account update quota permission (#19819) Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> * Cache image list with digest key (#19801) fixes #19429 Signed-off-by: stonezdj <[email protected]> Co-authored-by: stonezdj <[email protected]> * Add quota permissions testcase (#19822) Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> * deprecate gosec in makefile (#19828) remove the unused the part from makefile Signed-off-by: wang yan <[email protected]> * Add verification that robot account duration is not 0 (#19829) Signed-off-by: Yang Jiao <[email protected]> * fix artifact page bug (#19807) * fix artifact page bug * update testcase * Upgrade to distribution (registry) v3 alpha This includes all the benefits of the v3 distribution, but also all breaking changes. Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers. Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3. Signed-off-by: Aaron Dewes <[email protected]> --------- Signed-off-by: Lars Lehtonen <[email protected]> Signed-off-by: Yang Jiao <[email protected]> Signed-off-by: stonezdj <[email protected]> Signed-off-by: wang yan <[email protected]> Signed-off-by: Aaron Dewes <[email protected]> Co-authored-by: Lars Lehtonen <[email protected]> Co-authored-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> Co-authored-by: stonezdj(Daojun Zhang) <[email protected]> Co-authored-by: stonezdj <[email protected]> Co-authored-by: Wang Yan <[email protected]> Co-authored-by: ShengqiWang <[email protected]>
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Lars Lehtonen <[email protected]> Signed-off-by: Altynbaev Dinislam <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up a dropped test
err
variable inregistryctl/api/registry/blob
.