Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security hub API test case #19376

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Sep 20, 2023

Fix #19269

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #19376 (61f5f3d) into main (4051b2b) will decrease coverage by 3.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19376      +/-   ##
==========================================
- Coverage   70.63%   67.47%   -3.17%     
==========================================
  Files         744      988     +244     
  Lines       95272   108688   +13416     
  Branches        0     2752    +2752     
==========================================
+ Hits        67299    73332    +6033     
- Misses      24336    31408    +7072     
- Partials     3637     3948     +311     
Flag Coverage Δ
unittests 67.47% <ø> (-3.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 252 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) September 20, 2023 10:32
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 50e466b into goharbor:main Sep 20, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add security hub API test case
5 participants