-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support customize cache db for business #19184
Merged
zyyw
merged 1 commit into
goharbor:release-2.8.0
from
chlins:release-2.8/fix/seperate-redis-db
Aug 15, 2023
Merged
fix: support customize cache db for business #19184
zyyw
merged 1 commit into
goharbor:release-2.8.0
from
chlins:release-2.8/fix/seperate-redis-db
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wy65701436
reviewed
Aug 15, 2023
MinerYang
reviewed
Aug 15, 2023
wy65701436
reviewed
Aug 15, 2023
wy65701436
reviewed
Aug 15, 2023
wy65701436
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Support to configure the customized redis db for cache layer and other misc business for core, by default the behavior is same with previous(stored in db 0). Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
release-2.8/fix/seperate-redis-db
branch
from
August 15, 2023 08:13
3461bc7
to
7a933e2
Compare
Codecov Report
@@ Coverage Diff @@
## release-2.8.0 #19184 +/- ##
=================================================
- Coverage 67.40% 67.33% -0.07%
=================================================
Files 984 984
Lines 107051 107069 +18
Branches 2671 2671
=================================================
- Hits 72154 72093 -61
- Misses 31020 31095 +75
- Partials 3877 3881 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to configure the customized redis db for cache layer and other misc business for core, by default the behavior is same with previous(stored in db 0).
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #19169
Please indicate you've done the following: