Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Bump up setup-gcloud to 430.0.0 #19117

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Aug 8, 2023

Bump up setup-gcloud to 430.0.0

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Bump up setup-gcloud to 430.0.0

Signed-off-by: Yang Jiao <[email protected]>
@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Aug 8, 2023
@YangJiao0817 YangJiao0817 self-assigned this Aug 8, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner August 8, 2023 01:40
@YangJiao0817 YangJiao0817 changed the title Bump up setup-gcloud to 430.0.0 [cherry-pick]Bump up setup-gcloud to 430.0.0 Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #19117 (30d189d) into release-2.8.0 (cd31bcb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19117      +/-   ##
=================================================
- Coverage          67.38%   67.36%   -0.02%     
=================================================
  Files                984      984              
  Lines             107027   107027              
  Branches            2671     2671              
=================================================
- Hits               72118    72100      -18     
- Misses             31027    31045      +18     
  Partials            3882     3882              
Flag Coverage Δ
unittests 67.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 36c452b into goharbor:release-2.8.0 Aug 8, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants