Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve repo_read_only header on the UI #18729

Merged
merged 1 commit into from
May 24, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented May 24, 2023

  1. Fixes The Read_only header on Harbor UI should be visible for every user #18694
  2. Now non-system-admin users can also see the repo_read_only header
    Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner May 24, 2023 04:27
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label May 24, 2023
1. Fixes goharbor#18694
2. Now non-system-admin users can also see the repo_read_only header

Signed-off-by: AllForNothing <[email protected]>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #18729 (0648cea) into main (43c6586) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18729      +/-   ##
==========================================
- Coverage   67.37%   67.37%   -0.01%     
==========================================
  Files         980      980              
  Lines      106749   106739      -10     
  Branches     2668     2665       -3     
==========================================
- Hits        71927    71918       -9     
- Misses      30958    30960       +2     
+ Partials     3864     3861       -3     
Flag Coverage Δ
unittests 67.37% <82.35%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ide-nav/config/system/system-settings.component.ts 53.06% <ø> (+3.06%) ⬆️
...shared/components/navigator/navigator.component.ts 32.00% <ø> (+0.83%) ⬆️
.../shared/router-guard/auth-user-activate.service.ts 22.22% <ø> (+2.22%) ⬆️
...src/app/shared/services/message-handler.service.ts 18.91% <ø> (-3.59%) ⬇️
...count-settings/account-settings-modal.component.ts 73.93% <76.92%> (-0.14%) ⬇️
...ell/app-level-alerts/app-level-alerts.component.ts 53.73% <100.00%> (+3.00%) ⬆️

... and 10 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit c399e5e into goharbor:main May 24, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Fixes goharbor#18694
2. Now non-system-admin users can also see the repo_read_only header

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Fixes goharbor#18694
2. Now non-system-admin users can also see the repo_read_only header

Signed-off-by: AllForNothing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Read_only header on Harbor UI should be visible for every user
5 participants