【optimization】Use URL.Redacted method repleace redacted #18716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18716 +/- ##
==========================================
- Coverage 67.39% 67.38% -0.02%
==========================================
Files 980 980
Lines 106759 106730 -29
Branches 2665 2665
==========================================
- Hits 71955 71919 -36
- Misses 30941 30947 +6
- Partials 3863 3864 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/label release-note/update |
lengrongfu
force-pushed
the
opt/replace-redacted-method
branch
from
0af0907
to
fc34f1c
Compare
lengrongfu
force-pushed
the
opt/replace-redacted-method
branch
from
7c06cfe
to
5339719
Compare
|
Excuse me, is there anything else I need to do for this PR? |
Signed-off-by: lengrongfu <[email protected]>
chlins
force-pushed
the
opt/replace-redacted-method
branch
from
5339719
to
1a57815
Compare
@lengrongfu Thanks, no additional steps need to do, will merge it after CI passed. |
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
use URL.Redacted method replease redacted Signed-off-by: lengrongfu <[email protected]> Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
use URL.Redacted method replease redacted Signed-off-by: lengrongfu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
release-note/update
Please indicate you've done the following: