Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retain image last pull time API test case #18689

Merged
merged 1 commit into from
May 19, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented May 17, 2023

Fix #18618

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #18689 (f061160) into main (6a79de7) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18689      +/-   ##
==========================================
- Coverage   67.38%   67.38%   -0.01%     
==========================================
  Files         980      980              
  Lines      106749   106749              
  Branches     2668     2668              
==========================================
- Hits        71933    71930       -3     
- Misses      30954    30958       +4     
+ Partials     3862     3861       -1     
Flag Coverage Δ
unittests 67.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@YangJiao0817 YangJiao0817 marked this pull request as draft May 17, 2023 08:57
@YangJiao0817 YangJiao0817 force-pushed the add-skip-pull-time branch 2 times, most recently from 64cbc6f to 7855ec9 Compare May 18, 2023 02:44
@YangJiao0817 YangJiao0817 marked this pull request as ready for review May 18, 2023 06:25
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 2016d32 into goharbor:main May 19, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Retain image "last pull time" on scanning API test case
6 participants