Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing i18n key-value for helm chart #18578

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Apr 23, 2023

1.Fixes #18572

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #18578 (39d7e9e) into main (52d980e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18578      +/-   ##
==========================================
+ Coverage   67.38%   67.40%   +0.01%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
+ Hits        72108    72125      +17     
+ Misses      31024    31005      -19     
- Partials     3878     3880       +2     
Flag Coverage Δ
unittests 67.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@AllForNothing AllForNothing merged commit dd973b1 into goharbor:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression [2.8.0]: OCI Helm artifact UI is missing strings (all languages)
5 participants