Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce configurable concurrency in gc run #18576

Closed
wants to merge 1 commit into from

Conversation

hemanth132
Copy link

@hemanth132 hemanth132 commented Apr 22, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Introduced configurable concurrency within a gc run to speed up the GC

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: hemanth132 <[email protected]>
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #18576 (5b8fc02) into main (52d980e) will decrease coverage by 22.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18576       +/-   ##
===========================================
- Coverage   67.38%   44.70%   -22.69%     
===========================================
  Files         984      235      -749     
  Lines      107010    13089    -93921     
  Branches     2670     2670               
===========================================
- Hits        72108     5851    -66257     
+ Misses      31024     6944    -24080     
+ Partials     3878      294     -3584     
Flag Coverage Δ
unittests 44.70% <ø> (-22.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 753 files with indirect coverage changes

@wy65701436 wy65701436 assigned wy65701436 and zyyw and unassigned stonezdj, OrlinVasilev and chlins May 8, 2023
@hemanth132
Copy link
Author

@wy65701436 @zyyw hey folks, waiting for your review. let me know if something is missing.

@Vad1mo
Copy link
Member

Vad1mo commented Jun 13, 2023

@hemanth132 can you add some tests to your code?

@Vad1mo
Copy link
Member

Vad1mo commented Jun 23, 2023

@hemanth132, can you join the Harbor Slack channel to continue our discussion?

@wy65701436
Copy link
Contributor

Hi @hemanth132, thank you for your contribution. Regarding the multiple deletion issue, it has already been addressed in #18855.

For the multiple deletion feature, I suggest narrowing it down to the sweep phase since it won't take up too much time in the mark phase. However, it needs to handle the API and front-end IO as well.

And would you mind to close this pull request?

@wy65701436 wy65701436 added Stale and removed never-stale Do not stale release-note/update Update or Fix labels Jul 18, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

7 participants