-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add external redis username config to support redis6 ACL #18364
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18364 +/- ##
===========================================
+ Coverage 44.49% 70.66% +26.16%
===========================================
Files 233 741 +508
Lines 13022 93388 +80366
Branches 2660 0 -2660
===========================================
+ Hits 5794 65991 +60197
- Misses 6933 23839 +16906
- Partials 295 3558 +3263
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
revert make/prepare file revert beego/beego to v2.0.6 revert prometheus version && revise yml commennt about redis username update go.mod file Signed-off-by: yminer <[email protected]>
issue-18892 could be bypassed by follow this FAQ |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
#15895
Please indicate you've done the following: