Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add external redis username config to support redis6 ACL #18364

Merged
merged 1 commit into from
Mar 17, 2023
Merged

add external redis username config to support redis6 ACL #18364

merged 1 commit into from
Mar 17, 2023

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Mar 16, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#15895

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner March 16, 2023 09:26
@MinerYang MinerYang changed the title add external redis username o support redis6 ACL add external redis username config to support redis6 ACL Mar 16, 2023
@MinerYang MinerYang added the release-note/update Update or Fix label Mar 16, 2023
@MinerYang MinerYang requested review from wy65701436 and chlins March 16, 2023 09:27
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #18364 (48a83b4) into main (321d8a0) will increase coverage by 26.16%.
The diff coverage is n/a.

❗ Current head 48a83b4 differs from pull request most recent head de38b4e. Consider uploading reports for the commit de38b4e to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18364       +/-   ##
===========================================
+ Coverage   44.49%   70.66%   +26.16%     
===========================================
  Files         233      741      +508     
  Lines       13022    93388    +80366     
  Branches     2660        0     -2660     
===========================================
+ Hits         5794    65991    +60197     
- Misses       6933    23839    +16906     
- Partials      295     3558     +3263     
Flag Coverage Δ
unittests 70.66% <ø> (+26.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 974 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

revert make/prepare file

revert beego/beego to v2.0.6

revert prometheus version && revise yml commennt about redis username

update go.mod file

Signed-off-by: yminer <[email protected]>
@MinerYang
Copy link
Contributor Author

issue-18892 could be bypassed by follow this FAQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants