-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending signals by closing the channel #17917
Conversation
e21ef5c
to
0e8f966
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17917 +/- ##
===========================================
- Coverage 67.56% 46.03% -21.54%
===========================================
Files 991 246 -745
Lines 109181 13565 -95616
Branches 2719 2781 +62
===========================================
- Hits 73768 6244 -67524
+ Misses 31449 7004 -24445
+ Partials 3964 317 -3647
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
0e8f966
to
9fc0c11
Compare
@Iceber, can you briefly explain what problem your PR solves or addresses, is there an issue related to that? |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Removed the stale |
@OrlinVasilev Sorry, lots of things going on. This is just a small optimization of the convention of using channels as end signal notifications. |
6634fe0
to
123846e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
123846e
to
5cc3d91
Compare
Signed-off-by: Iceber Gu <[email protected]>
5cc3d91
to
1b36c7b
Compare
his is just a small optimization of the convention of using channels as end signal notifications.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
The end signal is usually sent by closing the channel
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: