Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2 enabled and ciphers changed to get an A+ rating instead of B fr… #16990

Merged
merged 8 commits into from
May 29, 2023
Merged

http2 enabled and ciphers changed to get an A+ rating instead of B fr… #16990

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a94fe7d
Make strong cipher cfg optional
Feb 16, 2023
27fec4c
Make strong cipher cfg optional
Feb 16, 2023
9fd2620
Make strong cipher cfg optional
Feb 16, 2023
d4009fe
Merge branch 'main' into enable_http2_and_use_more_secure_ciphers
wy65701436 Mar 13, 2023
c97d6d8
Merge branch 'main' into enable_http2_and_use_more_secure_ciphers
wy65701436 Apr 3, 2023
f4688fa
Merge branch 'main' into enable_http2_and_use_more_secure_ciphers
wy65701436 May 18, 2023
30c8460
Merge branch 'main' into enable_http2_and_use_more_secure_ciphers
MinerYang May 24, 2023
bed2808
Merge branch 'main' into enable_http2_and_use_more_secure_ciphers
MinerYang May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions make/harbor.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ https:
# enabled: true
# # put your cert and key files on dir
# dir: /etc/harbor/tls/internal
# # enable strong ssl ciphers (default: false)
# strong_ssl_ciphers: false

# Uncomment external_url if you want to enable external proxy
# And when it enabled the hostname will no longer used
Expand Down
5 changes: 4 additions & 1 deletion make/photon/prepare/templates/portal/nginx.conf.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@ http {
ssl_certificate /etc/harbor/tls/portal.crt;
ssl_certificate_key /etc/harbor/tls/portal.key;

# Recommendations from https://raymii.org/s/tutorials/Strong_SSL_Security_On_nginx.html
ssl_protocols TLSv1.2;
{% if internal_tls.strong_ssl_ciphers %}
ssl_ciphers ECDHE+AESGCM:DHE+AESGCM:ECDHE+RSA+SHA256:DHE+RSA+SHA256:!AES128;
{% else %}
ssl_ciphers '!aNULL:kECDH+AESGCM:ECDH+AESGCM:RSA+AESGCM:kECDH+AES:ECDH+AES:RSA+AES:';
{% endif %}
ssl_prefer_server_ciphers on;
ssl_session_cache shared:SSL:10m;
{% else %}
Expand Down