Skip to content

Update header user xpath#16917

Merged
YangJiao0817 merged 1 commit intogoharbor:mainfrom
YangJiao0817:update-head_admin_xpath
May 27, 2022
Merged

Update header user xpath#16917
YangJiao0817 merged 1 commit intogoharbor:mainfrom
YangJiao0817:update-head_admin_xpath

Conversation

@YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented May 27, 2022

Update it because #16796 modifies head_admin_xpath.

Signed-off-by: Yang Jiao jiaoya@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16916

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Update it because goharbor#16796 modifies header user.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels May 27, 2022
@YangJiao0817 YangJiao0817 requested review from chlins and wy65701436 May 27, 2022 08:18
@YangJiao0817 YangJiao0817 self-assigned this May 27, 2022
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner May 27, 2022 08:18
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #16917 (9b154e7) into main (b356d58) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16917      +/-   ##
==========================================
- Coverage   67.29%   67.27%   -0.03%     
==========================================
  Files         970      970              
  Lines       81267    81267              
  Branches     2550     2550              
==========================================
- Hits        54692    54669      -23     
- Misses      22874    22896      +22     
- Partials     3701     3702       +1     
Flag Coverage Δ
unittests 67.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g-retention-tasks/tag-retention-tasks.component.ts 61.11% <0.00%> (-25.00%) ⬇️
src/common/rbac/system/namespace.go 33.33% <0.00%> (-11.12%) ⬇️
src/jobservice/runner/redis.go 62.60% <0.00%> (-5.22%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.90% <0.00%> (-5.16%) ⬇️
...-nav/gc-page/gc/gc-history/gc-history.component.ts 61.11% <0.00%> (+9.25%) ⬆️

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 93f3bb1 into goharbor:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update head admin xpath

3 participants