support robot to list project#15431
Merged
wy65701436 merged 1 commit intogoharbor:masterfrom Aug 17, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15431 +/- ##
==========================================
- Coverage 66.79% 66.78% -0.02%
==========================================
Files 927 927
Lines 76017 76046 +29
Branches 2248 2248
==========================================
+ Hits 50779 50784 +5
- Misses 21309 21337 +28
+ Partials 3929 3925 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
force-pushed
the
robot-replication
branch
3 times, most recently
from
64aacff to
50c5e26
Compare
1, add permission check for API of List Projects 2, add permission check for API of List Repositories 3, use the self defined query to handle both names and public query Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
force-pushed
the
robot-replication
branch
from
50c5e26 to
e2b6a3c
Compare
heww
reviewed
Aug 17, 2021
|
|
||
| var names []string | ||
| for _, v := range query.Names { | ||
| names = append(names, `'`+v+`'`) |
Contributor
There was a problem hiding this comment.
suggest using the lib/pg.QuoteLiteral here
heww
approved these changes
Aug 17, 2021
ywk253100
approved these changes
Aug 17, 2021
This was referenced Aug 18, 2021
yunkunrao
pushed a commit
to yunkunrao/harbor
that referenced
this pull request
Aug 19, 2021
1, add permission check for API of List Projects 2, add permission check for API of List Repositories 3, use the self defined query to handle both names and public query Signed-off-by: wang yan <wangyan@vmware.com>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Aug 25, 2021
1, add permission check for API of List Projects 2, add permission check for API of List Repositories 3, use the self defined query to handle both names and public query Signed-off-by: wang yan <wangyan@vmware.com>
lindhe
pushed a commit
to lindhe/harbor
that referenced
this pull request
Sep 22, 2021
1, add permission check for API of List Projects 2, add permission check for API of List Repositories 3, use the self defined query to handle both names and public query Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Nov 12, 2021
1, add permission check for API of List Projects 2, add permission check for API of List Repositories 3, use the self defined query to handle both names and public query Signed-off-by: wang yan <wangyan@vmware.com>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Mar 13, 2022
1, add permission check for API of List Projects 2, add permission check for API of List Repositories 3, use the self defined query to handle both names and public query Signed-off-by: wang yan <wangyan@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1, add permission check for API of List Project
2, use the self defined query to handle both names and public query
Signed-off-by: wang yan wangyan@vmware.com