Add content type and length in header#13805
Merged
stonezdj merged 2 commits intogoharbor:masterfrom Jan 6, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13805 +/- ##
==========================================
+ Coverage 62.64% 63.31% +0.66%
==========================================
Files 951 952 +1
Lines 61250 61886 +636
Branches 2154 2160 +6
==========================================
+ Hits 38372 39184 +812
+ Misses 18971 18713 -258
- Partials 3907 3989 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
force-pushed
the
201218_add_content_type_length
branch
5 times, most recently
from
f275ec9 to
ef5f073
Compare
Fixes goharbor#13740 Update ManifestExist to return Descriptor instead of digest For docker 20.10 or containerd, it HEAD the manifest before pull, then it GET the manifest with digest, add logic to handle this scenario and correlate the tag between the digest in proxy cache Signed-off-by: stonezdj <stonezdj@gmail.com>
stonezdj
force-pushed
the
201218_add_content_type_length
branch
3 times, most recently
from
d51756d to
95f278e
Compare
reasonerjt
reviewed
Jan 4, 2021
reasonerjt
reviewed
Jan 4, 2021
reasonerjt
reviewed
Jan 4, 2021
reasonerjt
reviewed
Jan 4, 2021
reasonerjt
reviewed
Jan 4, 2021
reasonerjt
reviewed
Jan 4, 2021
stonezdj
force-pushed
the
201218_add_content_type_length
branch
2 times, most recently
from
2c8e23c to
ca723b2
Compare
ywk253100
previously approved these changes
Jan 4, 2021
ywk253100
reviewed
Jan 4, 2021
ywk253100
reviewed
Jan 4, 2021
ywk253100
reviewed
Jan 4, 2021
ywk253100
reviewed
Jan 4, 2021
stonezdj
force-pushed
the
201218_add_content_type_length
branch
2 times, most recently
from
0598f40 to
796c4f1
Compare
stonezdj
force-pushed
the
201218_add_content_type_length
branch
2 times, most recently
from
ba1ee76 to
b29fe31
Compare
ywk253100
approved these changes
Jan 5, 2021
stonezdj
force-pushed
the
201218_add_content_type_length
branch
from
b29fe31 to
64d75d1
Compare
reasonerjt
approved these changes
Jan 5, 2021
stonezdj
force-pushed
the
201218_add_content_type_length
branch
from
d939526 to
bd2d80b
Compare
Separate manifest, manifest list and image index. Signed-off-by: stonezdj <stonezdj@gmail.com>
stonezdj
force-pushed
the
201218_add_content_type_length
branch
from
bd2d80b to
1d50be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13740
Update ManifestExist to return Descriptor instead of digest
Signed-off-by: stonezdj stonezdj@gmail.com