Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication issue caused by pagination in api. #856

Closed
reasonerjt opened this issue Sep 30, 2016 · 1 comment
Closed

Replication issue caused by pagination in api. #856

reasonerjt opened this issue Sep 30, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@reasonerjt
Copy link
Contributor

  1. create a new project;
  2. push image to this project until it has more than 10 repositories;
  3. make a replication for this project to another harbor;

the replication will be end when the another harbor gets 10 repositories.

@ywk253100 , I think we need to revisit the default behavior of api pagination, by default the api should probably return all data until there's paging parameters

@reasonerjt
Copy link
Contributor Author

Per discussion, the default page size should be the max page size, and the code should handle the case if the number of items exceeds the page size, i.e. it's the client code that need to make more than one API call and merge the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants