Update Ingress apiVersion for support Kubernetes v1.16

[ramrodo]

This PR is for update Ingress apiVersion from extensions/v1beta1 to networking.k8s.io/v1beta1 for supporting Kubernetes v1.16.

Closes #628

Signed-off-by: Rodolfo Martínez [email protected]

[heww]

Please use Capabilities to deal with this problem when both helm 2 and 3 support Capabilities feature. Thanks!

[ramrodo]

Thanks for the tip @heww. I just updated the PR.

[maxdanilov]

Hi 👋
Are there any updates on this?
We were wondering why the 1.4.1 chart is using a deprecated ingress version and found this PR.
Any estimation on when it will be released?

[ryan-a-baker]

Can we get this merged? This is blocking us from upgrading to 1.16.

[ryan-a-baker]

@reasonerjt or @ywk253100?

[stefannica]

Thanks, I recently ran into this problem myself, tried to fix it, but didn't see this PR was already open.

[ramrodo]

Thanks Stefan. There is pending one more review in order to merge this. Can anyone else help us with this @reasonerjt or @ywk253100?

[ryan-a-baker]

It was just pointed out to me that this actually shouldn't block anything on 1.16 (I tested and confirmed as well on 1.16). I was just assuming that it would block us because it came back on the mapkubeapis plugin as having a deprecated API. Ingresses aren't removed in 1.16, but instead in 1.22, which is what this PR resolves.

The v1.22 release will stop serving the following deprecated API versions in favor of newer and more stable API versions:

Ingress in the extensions/v1beta1 API version will no longer be served
Migrate to use the networking.k8s.io/v1beta1 API version, available since v1.14. Existing persisted data can be retrieved/updated via the new version.

https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

Still would be good to get this merged, but isn't blocking on 1.16 upgrades as I mentioned previously.

[reasonerjt]

Thanks and I'll write another PR to remove the if chunks as we'll only support v1.16+ for chart v1.5.0