Skip to content

Fix #18: Sleep induced slowness in gogits#24

Merged
unknwon merged 1 commit intogogs:masterfrom
thibaultmeyer:fix/18-sleep-induced-slowness
Dec 8, 2016
Merged

Fix #18: Sleep induced slowness in gogits#24
unknwon merged 1 commit intogogs:masterfrom
thibaultmeyer:fix/18-sleep-induced-slowness

Conversation

@thibaultmeyer
Copy link
Contributor

@thibaultmeyer thibaultmeyer commented Oct 30, 2016

This pull request remove usage of sleep function who slow down git repos browsing (Issue #18).

@strk
Copy link
Contributor

strk commented Oct 30, 2016

Why was the sleep there in the first place ? Lack of proper synchronization ?

@thibaultmeyer
Copy link
Contributor Author

thibaultmeyer commented Oct 30, 2016

I think the Sleep included on the function GetCommitsInfo (this function only read data) is useless but I'm not sure, maybe ask @unknwon. But in all cases, using Sleep is probably the worst solution.

@strk
Copy link
Contributor

strk commented Nov 6, 2016

@0xBAADF00D could you please migrate this to https://github.com/go-gitea/git ?

@unknwon
Copy link
Member

unknwon commented Dec 8, 2016

Thanks!

@unknwon unknwon merged commit 2ceb4d5 into gogs:master Dec 8, 2016
sapk pushed a commit to sapk-fork/git-module that referenced this pull request Mar 8, 2017
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants