[FEAT] add timeout to cook command and adjust command variable #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will merge this as it's a helpful addition, however I might change the CLI flag name before this makes it into a tagged version, as I want the timeout flag to work more globally. Thanks for the contribution! |
taigrr
pushed a commit
that referenced
this pull request
Sep 10, 2024
* add timeout to cook command and adjust command variable * a few updates to fix some bugs with the new cookTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
The problem is that sometimes the steps take longer than 30 seconds to complete. An example would be installing a larger package or a few packages.
Describe the solution you'd like
This seems like it'd be fairly easy to implement. I don't have much experience with go, but I took a stab at it taking examples from other files. I was able to compile and check this locally. Also, sorry for the two commits. I realized I should probably actually test what is wrote.
Additional context
I have been using grlx for my MVP and so far I'm excited about the direction it's heading!