Fix jsonpb to emit zero values for Map, Slice, Ptr when EmitDefaults=… #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…true
When jsonpb.Marshaler.EmitDefaults is set to true, marshal zero values
of the following types accordingly:
Map to {}
Slice to []
Ptr to null
Cherry-pick Eric Wang's commit: golang/protobuf@7a211bc
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
referenced
this pull request
in golang/protobuf
May 25, 2017
…true
When jsonpb.Marshaler.EmitDefaults is set to true, marshal zero values of the
following types accordingly:
Map to {}
Slice to []
Ptr to null
|
Thanks for your enthusiasm. |
|
Just merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…true
When jsonpb.Marshaler.EmitDefaults is set to true, marshal zero values
of the following types accordingly:
Map to {}
Slice to []
Ptr to null
Cherry-pick Eric Wang's commit: golang/protobuf@7a211bc
Signed-off-by: Akihiro Suda [email protected]