Show the use of proper gogo/googleapi types with status. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
2 times, most recently
from
f50526a
to
a916715
Compare
server/server.go
Outdated
| } | ||
|
|
||
| return nil, st.Err() | ||
| byts, _ := proto.Marshal(b) |
There was a problem hiding this comment.
Remember to check the error.
server/server.go
Outdated
| }, | ||
| }, | ||
| } | ||
| byts, _ := proto.Marshal(b) |
There was a problem hiding this comment.
Remember to check the error
server/server.go
Outdated
| "github.com/gogo/protobuf/types" | ||
| "google.golang.org/genproto/googleapis/rpc/errdetails" | ||
| pbAny "github.com/golang/protobuf/ptypes/any" |
There was a problem hiding this comment.
Are we still planning to get rid of these pbAny and pbStatus types and replace them with gogo types in future?
|
|
||
| "github.com/cockroachdb/cockroach/pkg/util/protoutil" | ||
| gogoproto "github.com/gogo/protobuf/proto" | ||
| golangproto "github.com/golang/protobuf/proto" |
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
from
a916715
to
72656a6
Compare
awalterschulze
approved these changes
Mar 18, 2018
status/README.md
Outdated
| The changes applies include changing the use of the | ||
| `golang/protobuf` packages to `gogo/protobuf`, and changing the | ||
| generated files from `google.golang.org/genproto/googleapis` to | ||
| `github.com/goog/googleapis/`. |
|
I'm going to remove the manual vendor changes and wait with merging this until upstream (grpc/grpc-go#1927) has been merged (or rejected 😭). |
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
from
72656a6
to
fdf1bbb
Compare
|
Sounds like a plan :)
…On Sun, 18 Mar 2018 at 16:06 Johan Brandhorst ***@***.***> wrote:
I'm going to remove the manual vendor changes and wait with merging this
until upstream (grpc/grpc-go#1927
<grpc/grpc-go#1927>) has been merged (or rejected
😭).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLUSM8jRNZlsiWaP5YvjWAgC1vhO2ks5tfngLgaJpZM4Su5sh>
.
|
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
from
fdf1bbb
to
c6c9366
Compare
johanbrandhorst
commented
Mar 24, 2018
Gopkg.toml
Outdated
| name = "google.golang.org/grpc" | ||
| version = "1.10.0" | ||
| # version = "1.10.0"# | ||
| source = "github.com/johanbrandhorst/grpc-go" |
There was a problem hiding this comment.
TODO: Revert back once grpc/grpc-go#1927 is merged
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
from
c6c9366
to
2113316
Compare
johanbrandhorst
commented
Mar 24, 2018
Gopkg.toml
Outdated
| branch = "patch-1" | ||
| name = "google.golang.org/grpc" | ||
| # version = "1.10.0"# | ||
| source = "github.com/johanbrandhorst/grpc-go" |
There was a problem hiding this comment.
TODO: Revert this once grpc/grpc-go#1927 is merged
johanbrandhorst
commented
Mar 24, 2018
Gopkg.toml
Outdated
| name = "github.com/golang/mock" | ||
| name = "github.com/mwitkow/go-proto-validators" | ||
|
|
||
| [[override]] |
There was a problem hiding this comment.
TODO: Set this back to [[constraint]]
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
from
2113316
to
799a991
Compare
|
Updated in anticipation of grpc/grpc-go#1927. Will just need setting the Gopkg.toml back then we can merge. |
|
Ooo wow. This looks great. I hope 1927 goes through. Great work. |
Adds an error detail to the ListUsers call in order to ensure both streaming and unary calls properly translate gogo statuses.
Upgrading to 1.11.0 revealed that we weren't using the ipv4 scheme at all as I expected. Now just pass through the raw localhost address instead.
johanbrandhorst
force-pushed
the
show-proper-use-of-errors
branch
from
799a991
to
751c4e8
Compare
|
I've update this with the new gRPC version, and gogo/status, and everything seems to work alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the use of
google.golang.org/genprotopackage types (except for the mandatory status type).