test(cmd/gf): enhance integration tests for gen pb command#4644
Merged
gqcn merged 1 commit intogogf:masterfrom Jan 21, 2026
Merged
test(cmd/gf): enhance integration tests for gen pb command#4644gqcn merged 1 commit intogogf:masterfrom
gqcn merged 1 commit intogogf:masterfrom
Conversation
Add 2 new test cases for gen pb command: - TestGenPb_MultipleTags: tests multiple validation tags and dc tags - TestGenPb_NestedMessage: tests nested message structures with tags Also add corresponding proto test data files: - testdata/genpb/multiple_tags.proto - testdata/genpb/nested_message.proto
gqcn
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gf gen pbcommandTestGenPb_MultipleTags: tests multiple validation tags (v:required, v:#Id > 0, v:email) and dc tagsTestGenPb_NestedMessage: tests nested message structures with various tag typesTest Data
testdata/genpb/multiple_tags.proto- proto file with multiple tag annotationstestdata/genpb/nested_message.proto- proto file with nested message structuresTest Plan
go test -v -run "TestGenPb" ./...- all 4 tests pass (2 existing + 2 new)