fix(cmd/gf): fix genservice losing versioned import paths (#4242)#4638
Merged
gqcn merged 3 commits intogogf:masterfrom Jan 22, 2026
Merged
fix(cmd/gf): fix genservice losing versioned import paths (#4242)#4638gqcn merged 3 commits intogogf:masterfrom
gqcn merged 3 commits intogogf:masterfrom
Conversation
gqcn
approved these changes
Jan 21, 2026
Member
|
lgtm |
The issue was that imports like "github.com/minio/minio-go/v7" were incorrectly handled because the code tried to infer package names from import paths, but Go allows package names to differ from directory names (e.g., path ends with "minio-go" but package is "minio"). Solution: Remove the faulty package name inference logic and keep all non-anonymous imports, letting gofmt clean up unused ones.
lingcoder
force-pushed
the
fix/issue-4242-genservice-import
branch
from
eec4139 to
756c9b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gf gen serviceincorrectly handling versioned imports (e.g.,github.com/minio/minio-go/v7→github.com/minio/minio-go)Changes
calculateImportedItemsfunction ingenservice_calculate.goTest plan
Test_Gen_Service_Default,Test_Issue3328,Test_Issue3835)Test_Issue4242verifies both versioned imports and aliased imports are preservedCloses #4242