fix(database/gdb): Raw SQL Count ignores Where condition#4611
Merged
hailaz merged 3 commits intogogf:masterfrom Jan 16, 2026
Merged
fix(database/gdb): Raw SQL Count ignores Where condition#4611hailaz merged 3 commits intogogf:masterfrom
hailaz merged 3 commits intogogf:masterfrom
Conversation
When using Raw() with Where() and Count()/ScanAndCount(), the Where conditions were being ignored in the Count query. This was because getFormattedSqlAndArgs() for SelectTypeCount with Raw SQL was returning nil for conditionArgs without calling formatCondition(). The fix adds formatCondition() call for Raw SQL in SelectTypeCount case, ensuring Where conditions are properly included in the subquery. Closes gogf#4500
lingcoder
force-pushed
the
hotfix/issue4500
branch
from
1f6677e to
7135fa1
Compare
… conditions (issue#4500)
hailaz
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raw()withWhere()andCount()/ScanAndCount()was ignoring the Where conditions in Count queriesgetFormattedSqlAndArgs()which returnednilforconditionArgswithout callingformatCondition()for Raw SQL inSelectTypeCountcaseChanges
database/gdb/gdb_model_select.goto callformatCondition()for Raw SQL Count queriesTest_Model_RawTest plan
Test_Issue4500with 6 edge cases covering:Closes #4500