Skip to content

feat(util/gvalid): add more rules: alpha,alpha-dash,alpha-num,lowercase,numeric,uppercase#4601

Merged
hailaz merged 4 commits intogogf:masterfrom
yuluo-yx:0109-yuluo/feat
Jan 15, 2026
Merged

feat(util/gvalid): add more rules: alpha,alpha-dash,alpha-num,lowercase,numeric,uppercase#4601
hailaz merged 4 commits intogogf:masterfrom
yuluo-yx:0109-yuluo/feat

Conversation

@yuluo-yx
Copy link
Contributor

@yuluo-yx yuluo-yx commented Jan 9, 2026

Add more check rules

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Copilot AI review requested due to automatic review settings January 9, 2026 12:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds six new validation rules to the GoFrame validation package for common string pattern validations. The rules include alpha, alpha-num, alpha-dash, numeric, lowercase, and uppercase validations.

  • Implements string pattern validators using regex matching
  • Follows the existing builtin validation rule pattern
  • Adds support for common validation scenarios

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
util/gvalid/internal/builtin/builtin_alpha.go Adds validation rule for alphabetic characters only (a-z, A-Z)
util/gvalid/internal/builtin/builtin_alpha_num.go Adds validation rule for alpha-numeric characters (a-z, A-Z, 0-9)
util/gvalid/internal/builtin/builtin_alpha_dash.go Adds validation rule for alpha-numeric characters with hyphens and underscores
util/gvalid/internal/builtin/builtin_lowercase.go Adds validation rule for lowercase alphabetic characters only (a-z)
util/gvalid/internal/builtin/builtin_numeric.go Adds validation rule for numeric strings only (0-9)
util/gvalid/internal/builtin/builtin_uppercase.go Adds validation rule for uppercase alphabetic characters only (A-Z)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gqcn
gqcn previously requested changes Jan 13, 2026
Copy link
Member

@gqcn gqcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuluo-yx Missing unit testing cases.

@gqcn gqcn added the missing unit testing cases Used in PR, the associated unit testing cases should be committed. label Jan 13, 2026
@gqcn gqcn changed the title feat: add more rule check feat(util/gvalid): add more rules: alpha,alpha-dash,alpha-num,lowercase,numeric,uppercase Jan 13, 2026
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
@yuluo-yx
Copy link
Contributor Author

@yuluo-yx Missing unit testing cases.

done

Copilot AI review requested due to automatic review settings January 14, 2026 06:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hailaz hailaz added ready to merge Used in PR, which means this PR is reviewed. and removed missing unit testing cases Used in PR, the associated unit testing cases should be committed. labels Jan 14, 2026
@hailaz hailaz merged commit be91c48 into gogf:master Jan 15, 2026
24 checks passed
@yuluo-yx yuluo-yx deleted the 0109-yuluo/feat branch January 15, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Used in PR, which means this PR is reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants