Remove double formatting in AST import replacer#4594
Merged
hailaz merged 2 commits intofix/gfinit0107from Jan 7, 2026
Merged
Conversation
The AST replacer now uses printer.Fprint instead of format.Node, deferring all formatting to the final utils.GoFmt call. This avoids double formatting of modified files and is more efficient since utils.GoFmt also handles import organization via golang.org/x/tools/imports. Co-authored-by: hailaz <29968474+hailaz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues from review on init command improvements
Remove double formatting in AST import replacer
Jan 7, 2026
hailaz
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #4592 regarding inefficient double formatting of Go files during project generation.
Changes
format.Nodewithprinter.Fprintin AST replacer to skip intermediate formattingutils.GoFmtcall which usesgolang.org/x/tools/importsPreviously, files modified by the AST replacer were formatted twice—once during import path replacement and again by the final
utils.GoFmtcall. Now the AST replacer writes unformatted AST, and a singleutils.GoFmtpass handles both formatting and import organization.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.