refactor(database/gdb): simplify order and group by alias quoting (bu…#4555
Merged
hailaz merged 4 commits intogogf:masterfrom Dec 26, 2025
Merged
refactor(database/gdb): simplify order and group by alias quoting (bu…#4555hailaz merged 4 commits intogogf:masterfrom
hailaz merged 4 commits intogogf:masterfrom
Conversation
…gfix/order-alias)
…der feature models Closes gogf#4554
Member
|
Thanks for your suggestion! We'll carefully consider and test it, though this may take a little time. We also welcome other guys who see this to join in code review and participate in the discussion. |
Contributor
|
撤销 #4521 的更改,自动前缀提高维护的复杂度,减少了透明度,增加了调试的难度。手动设置前缀更加直观和可预测。 |
hailaz
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Revert the auto table prefix behavior in
Order()andGroup()introduced by #4521.Why
PR #4521 attempted to resolve column ambiguity in GROUP BY/ORDER BY with MySQL JOIN by automatically adding table prefixes to unqualified columns. However,
this approach has issues:
.As()to set table alias, it uses the original table name instead of the alias, causing errors in PostgreSQL and other databasesExample of the issue (#4554)