feat(container/gqueue): add generic queuefeature#4497
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a generic queue implementation (TQueue[T]) to the gqueue package, enabling type-safe queue operations while maintaining backward compatibility with the existing non-generic Queue type.
Key changes:
- Added a new generic
TQueue[T any]type with type-safe methods - Refactored existing
Queueto use embeddedTQueue[any]for backward compatibility - Eliminated code duplication by consolidating queue logic in the generic implementation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| container/gqueue/gqueue_t.go | New file implementing generic TQueue[T] with all core queue operations |
| container/gqueue/gqueue.go | Refactored to embed TQueue[any] and delegate method calls, reducing code duplication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hailaz
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add TQueue