feat(container/gpool): add generic pool feature#4493
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a generic pool implementation TPool[T] to the gpool package and refactors the existing Pool type to use it as a foundation. The main purpose is to add type-safe generic pool functionality while maintaining backward compatibility with the existing Pool API.
Key Changes:
- Added a new generic
TPool[T]implementation with full pool functionality - Refactored
Poolto wrapTPool[any]instead of maintaining duplicate implementation - Unified the codebase by eliminating code duplication between generic and non-generic pool types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| container/gpool/gpool_t.go | Implements the new generic TPool[T] type with all pool operations (Get, Put, Clear, etc.) and expiration management |
| container/gpool/gpool.go | Refactored to delegate all operations to the embedded TPool[any], converting Pool into a thin wrapper for backward compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… generic tests for TPool
hailaz
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add TPool[T] and let Pool base on it.