Skip to content

refactor(cmd/gf): Optimize run command to reload only on actual file changes #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hailaz merged 2 commits into from
Oct 16, 2025
Merged

refactor(cmd/gf): Optimize run command to reload only on actual file changes #4476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
420c849
refactor(cmd/gf): 优化run命令使得只在文件有写入事件时才触发reload
windvalley Oct 16, 2025
1471203
fix(cmd/gf): 完善run命令触发reload的文件监控事件
windvalley Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cmd/gf/internal/cmd/cmd_run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ import (
"github.com/gogf/gf/cmd/gf/v2/internal/utility/mlog"
)

var (
Run = cRun{}
)
var Run = cRun{}

type cRun struct {
g.Meta `name:"run" usage:"{cRunUsage}" brief:"{cRunBrief}" eg:"{cRunEg}" dc:"{cRunDc}"`
Expand Down Expand Up @@ -63,9 +61,7 @@ which compiles and runs the go codes asynchronously when codes change.
cRunWatchPathsBrief = `watch additional paths for live reload, separated by ",". i.e. "manifest/config/*.yaml"`
)

var (
process *gproc.Process
)
var process *gproc.Process

func init() {
gtag.Sets(g.MapStrStr{
Expand Down Expand Up @@ -119,8 +115,12 @@ func (c cRun) Index(ctx context.Context, in cRunInput) (out *cRunOutput, err err
}
dirty := gtype.NewBool()

var outputPath = app.genOutputPath()
outputPath := app.genOutputPath()
callbackFunc := func(event *gfsnotify.Event) {
if !event.IsWrite() && !event.IsCreate() && !event.IsRemove() && !event.IsRename() {
return
}

if gfile.ExtName(event.Path) != "go" {
return
}
Expand Down
Loading