fix(contrib/drivers/pgsql): Merge duplicated fields, especially for key constraints.#4465
Merged
hailaz merged 1 commit intogogf:masterfrom Oct 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements proper merging of key information for PostgreSQL table fields when multiple constraints exist on the same field. The changes ensure that when a field has multiple constraints (e.g., both primary key and unique), the TableFields method correctly prioritizes and merges the key information with the hierarchy: pri > uni > others.
Key changes:
- Modified field processing logic to merge duplicate field entries instead of skipping them
- Implemented constraint priority system where primary key takes precedence over unique constraints
- Added comprehensive test coverage for both single and composite constraint scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| contrib/drivers/pgsql/pgsql_table_fields.go | Updated field processing logic to merge key constraints with proper priority handling |
| contrib/drivers/pgsql/pgsql_z_unit_db_test.go | Added test cases to verify correct merging of field constraints and composite primary keys |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e98f927 to
d8d88c4
Compare
hailaz
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgsql 执行TableFields 或者字段信息时需要合并key信息