fix(database/gdb): performance improvement in fields grouping when in…#4440
Merged
hailaz merged 6 commits intogogf:masterfrom Sep 26, 2025
Merged
fix(database/gdb): performance improvement in fields grouping when in…#4440hailaz merged 6 commits intogogf:masterfrom
hailaz merged 6 commits intogogf:masterfrom
Conversation
…serting batch data fix(database/gdb): performance improvement in fields grouping when inserting batch data
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance in the database fields grouping logic during batch insert operations by reducing redundant operations. The optimization specifically addresses issue #3906 by caching field combinations and minimizing calls to the expensive fieldsToSequence method.
Key changes:
- Optimizes field grouping logic by pre-sorting keys and caching field combinations
- Reduces redundant
fieldsToSequencecalls by grouping items with identical field sets - Adds benchmark test to measure batch insert performance improvements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| database/gdb/gdb_core.go | Refactors DoInsert method to cache field combinations and reduce redundant operations |
| contrib/drivers/mysql/mysql_z_unit_core_bench_test.go | Adds benchmark test for batch insert operations to validate performance improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@wanghaolonggit 做了一点点修改,复查一下 |
Contributor
Author
好 |
fix(database/gdb): fix mysql different fields batch insert test case
9c50d07 to
e7ece8f
Compare
Contributor
Author
@hailaz 修改的特别好,我另外加了一个测试用例 |
Contributor
Author
Contributor
Contributor
Author
hailaz
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fix #3906