Skip to content

fix(net/gclient): fix content-type 'application/json;charset=utf-8' … #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hailaz merged 6 commits into from
Oct 15, 2025
Merged

fix(net/gclient): fix content-type 'application/json;charset=utf-8' … #4369

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b38366
fix(net/gclient): fix content-type 'application/json;charset=utf-8' …
wanghaolong613 Aug 15, 2025
7006952
Merge branch 'master' into fix/content-type
wanghaolong613 Aug 18, 2025
7044dde
Merge branch 'master' into fix/content-type
wanghaolong613 Aug 25, 2025
c390aec
Merge branch 'master' into fix/content-type
houseme Sep 1, 2025
d7e6c79
fix(net/gclient): fix content-type 'application/json;charset=utf-8' …
wanghaolong613 Sep 4, 2025
ec23565
Merge branch 'master' into fix/content-type
wanghaolong613 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions net/gclient/gclient_request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"bytes"
"context"
"io"
"mime"
"mime/multipart"
"net/http"
"os"
Expand Down Expand Up @@ -172,7 +173,12 @@ func (c *Client) prepareRequest(ctx context.Context, method, url string, data ..
allowFileUploading = true
)
if len(data) > 0 {
switch c.header[httpHeaderContentType] {
mediaType, _, err := mime.ParseMediaType(c.header[httpHeaderContentType])
if err != nil {
// Fallback: use the raw header value if parsing fails.
mediaType = c.header[httpHeaderContentType]
}
switch mediaType {
case httpHeaderContentTypeJson:
switch data[0].(type) {
case string, []byte:
Expand Down Expand Up @@ -206,7 +212,12 @@ func (c *Client) prepareRequest(ctx context.Context, method, url string, data ..
if method == http.MethodGet {
var bodyBuffer *bytes.Buffer
if params != "" {
switch c.header[httpHeaderContentType] {
mediaType, _, err := mime.ParseMediaType(c.header[httpHeaderContentType])
if err != nil {
// Fallback: use the raw header value if parsing fails.
mediaType = c.header[httpHeaderContentType]
}
switch mediaType {
case
httpHeaderContentTypeJson,
httpHeaderContentTypeXml:
Expand Down
Loading