Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(database/gdb): fix context canceled error in transaction due to usage of TransTimeout configuration #4037

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix(database/gdb): fix context canceled error in transaction due to usage of TransTimeout configuration #4037

merged 4 commits into from
Dec 17, 2024

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Dec 12, 2024 •
edited
Loading

fix #4034

@gqcn gqcn marked this pull request as ready for review December 12, 2024 02:13
weimx2023
weimx2023 reviewed Dec 12, 2024
View reviewed changes
Copy link

@weimx2023 weimx2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic implementation looks sound. For future enhancements to the configuration functionality, we should consider:

1.Adding new configuration parameters to support extensibility
2.Leveraging AI to generate test cases for code logic modifications

wln32
wln32 reviewed Dec 13, 2024
View reviewed changes
@wln32
Copy link
Member

wln32 commented Dec 13, 2024

@gqcn 我好像发现了超时设置在有些地方重复了？
doquery
doexec
docommit

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@gqcn I seem to have found that the timeout settings are repeated in some places?
doquery
doexec
docommit

@gqcn
Copy link
Member Author

gqcn commented Dec 16, 2024

@gqcn 我好像发现了超时设置在有些地方重复了？ doquery doexec docommit

好的，我看看呢。

@gqcn gqcn merged commit f79aef6 into master Dec 17, 2024
34 checks passed
@gqcn gqcn deleted the fix/4034 branch December 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weimx2023 weimx2023 weimx2023 left review comments

@wln32 wln32 wln32 approved these changes

@houseme houseme Awaiting requested review from houseme

@joy999 joy999 Awaiting requested review from joy999

@hailaz hailaz Awaiting requested review from hailaz

@oldme-git oldme-git Awaiting requested review from oldme-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

database/gdb: context canceled
4 participants
@gqcn @wln32 @Issues-translate-bot @weimx2023