Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contrib/drivers/mssql): fix mssql paging sql generate statement error #3782

Merged
merged 7 commits into from
Sep 29, 2024
Merged

fix(contrib/drivers/mssql): fix mssql paging sql generate statement error #3782

merged 7 commits into from
Sep 29, 2024

Conversation

freesme
Copy link
Contributor

@freesme freesme commented Sep 14, 2024

fixed #3343

@gqcn gqcn requested review from hailaz and wln32 September 19, 2024 06:23
@gqcn
Copy link
Member

gqcn commented Sep 19, 2024

There seems some problem with the CI, I'll check the CI later by later.

gqcn
gqcn requested changes Sep 23, 2024
View reviewed changes
contrib/drivers/mssql/mssql_do_filter.go Outdated Show resolved Hide resolved
contrib/drivers/mssql/mssql_do_filter_test.go Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
37.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

freesme
freesme commented Sep 23, 2024
View reviewed changes
Copy link
Contributor Author

@freesme freesme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gqcn Thank you for your review. I have completed the modification of these two items.

@freesme freesme requested a review from gqcn September 23, 2024 07:02
@gqcn
Copy link
Member

gqcn commented Sep 23, 2024

@freesme Hello, this PR will be blocked as there's some issue in mssql driver docker service in ci. This PR will be merged after the mssql driver docker service resumes.

@gqcn gqcn added the ready to merge Used in PR, which means this PR is reviewed. label Sep 23, 2024
@gqcn gqcn merged commit 8e7f118 into gogf:master Sep 29, 2024
20 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

@hailaz hailaz Awaiting requested review from hailaz

@wln32 wln32 Awaiting requested review from wln32

Assignees
No one assigned
Labels
ready to merge Used in PR, which means this PR is reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

method "Page(page,limit)" generate paging sql is incorrect where database type is not mysql
3 participants
@freesme @gqcn @houseme