Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net/ghttp): server shutdown not graceful using admin api /debug/admin/shutdown #3777

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(net/ghttp): server shutdown not graceful using admin api /debug/admin/shutdown #3777

merged 3 commits into from
Sep 19, 2024

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Sep 13, 2024

fixed #3358

@gqcn gqcn changed the title fix(net/ghttp): #3358 server shutdown not graceful using admin api /debug/admin/shutdown fix(net/ghttp): server shutdown not graceful using admin api /debug/admin/shutdown Sep 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gqcn gqcn merged commit c4327f6 into master Sep 19, 2024
47 checks passed
@gqcn gqcn deleted the fix/3358 branch September 19, 2024 06:10
houseme added a commit that referenced this pull request Sep 23, 2024
@houseme
Merge branch 'feature/go-1.20' of github.com:gogf/gf into feature/go-…
2fc1562 
…1.20

* 'feature/go-1.20' of github.com:gogf/gf:
  ci: fix mssql docker service failed in ci (#3792)
  fix(net/ghttp): server shutdown not graceful using admin api `/debug/admin/shutdown` (#3777)
@BrewTestBot BrewTestBot mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wln32 wln32 wln32 approved these changes

@oldme-git oldme-git oldme-git approved these changes

@houseme houseme houseme approved these changes

@huangqian1985 huangqian1985 Awaiting requested review from huangqian1985

@DGuang21 DGuang21 Awaiting requested review from DGuang21

@hailaz hailaz Awaiting requested review from hailaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/ghttp: /debug/admin/shutdown is not graceful shutdown
4 participants
@gqcn @houseme @oldme-git @wln32